search

tillkruss / Nginx-FastCGI-Cache

A WordPress plugin that purges Nginx cache zones.
48 stars 25 forks source link

Register purge actions in 'after_setup_theme' hook. #14

Closed chesio closed 6 years ago

chesio commented 6 years ago

Fixes #13.

tillkruss commented 6 years ago

What do you think about using the wp_loaded or init action instead of after_setup_theme?

chesio commented 6 years ago

Good point. From the perspective of what I want to fix with this PR (being able to use the filter from a theme), I think there's no difference between the three as long as there's the did_action() check in place. This said, both wp_loaded and init feel semantically more suitable than after_setup_theme, so feel free to change the hook. Personally, I would opt for init as this is the hook usually used for plugin initialization stuff.

tillkruss commented 6 years ago

Thanks!