search

tillmo / DOL

The Distributed Ontology, Modeling and Specification Language (DOL) - an answer to the OMG RFP OntoIOp. * View the latest version here: https://github.com/tillmo/DOL/raw/master/Standard/dol.pdf. * Convenience version with diff to version of August 24: https://github.com/tillmo/DOL/raw/master/Standard/dol-diff.pdf * Homepage of OntoIOp is
http://ontoiop.org
7 stars 1 forks source link

Nodes and edges are not well defined #326

Closed tillmo closed 7 years ago

tillmo commented 7 years ago

In the DOL ontology, LanguageGraph and LogicGraph: Explicitly state what the nodes and what the edges are

see http://issues.omg.org/browse/DOL-23

tillmo commented 7 years ago

see 326_define_nodes_and_edges of git@ontohub.org:meta.git Text for FTF: we have now explicitly stated what nodes and edges are.

fabianneuhaus commented 7 years ago

@tillmo I believe the diff is not correct. It is about LanguageMapping, but you changed the definition of LogicGraph

tillmo commented 7 years ago

The diff is not about LanguageMapping. A diff consists of a sequence of hunks. Each hunk starts with @@, and provides some context around the changed lines. Please look at the context at the start of a hunk, not at the end.

fabianneuhaus commented 7 years ago

Is there a way to guarantee that the hunk includes the relevant class declaration? Because the information that the second hunk is about LogicGraph is missing.

Update: Because the last line of the previous hunk is a declaration of a class (LanguageMapping) this is easy to misread. I just copy the relevant information from the RDF file manually.

fabianneuhaus commented 7 years ago

OMG proposal added

tillmo commented 7 years ago

with git diff -Un one can enlarge the context of a hunk to n lines (default is 3).