search

tillnagel / unfolding

A library to create interactive maps and geovisualizations in Processing and Java
http://unfoldingmaps.org
Other
477 stars 245 forks source link

Update examples source code #139

Closed Evegen55 closed 7 years ago

Evegen55 commented 7 years ago

There are lots of good examples how we can use Unfolding but have been written for Processing 2.2.1. Since version 3 the Processing language not support Applet and has another way for create main application. In this fork we can use all examples with last version of the Processing libraries for Java. All examples work correctly.

tillnagel commented 7 years ago

Thanks so much for your efforts!

However, for me to merge please do not use your own code style. Also, please do not change the modifiers. And lastly, uppercase variable names should be used for final variables only.

Evegen55 commented 7 years ago

Thanks a lot for notes! ok, may be I'll do it in another branch and maybe it will take couple of days. But what would you tell about two serios fixes - commit "TODO Move addUniqueMarkers to UnfoldingMap. - resolved" and "fix bug with MarkerFactory"? Also about commit "add javaDoc task for examples, add note for HelloWorld"? Should I implement it in another branch?

tillnagel commented 7 years ago

Let me try and cherry pick those commits, on the weekend. I'll come back to you if I face issues regarding this.

Evegen55 commented 7 years ago

ok, thanks!

Evegen55 commented 7 years ago

I have another question - what about @override annotation? May be I could try to paste in appropriate places?