search

tillsteinbach / WeConnect-python

Python API for the Volkswagen WeConnect Services
MIT License
105 stars 27 forks source link

Fails to install on homeassistant 2024.6.1 due to incompatible requests version #192

Closed bssstudio closed 3 weeks ago

bssstudio commented 1 month ago

Describe the bug Fails to install on home assistant version 2024.6.1 due to incompatible requests version.

To Reproduce 1) Update homeassistant to 2024.6.1 2) Install custom integration We Connect ID (https://github.com/mitch-dc/volkswagen_we_connect_id)

Expected behavior Homeassistant successfully installs weconnect-python.

Please bump the requests version to 2.32.3 (#189)

zxdavb commented 1 month ago

@tillsteinbach Would you consider specifying requests>=2.31.0 instead of requests~=2.31.0?

I think the latter is ill-advised for a client library (although it is better than requests==2.31.0).

Something like home-assistant will pin versions - and that is best practice, but this is not the case of client libraries like this.

pdcastro commented 1 month ago

Would you consider specifying requests>=2.31.0 instead of requests~=2.31.0?

Or at least pin the major version only, not the minor, given semver semantics.

Per PEP spec, ~=2.31.0 means >=2.31.0, ==2.31.*, i.e. pinned at minor version 2.31. Semver in theory guarantees that all 2.X versions are API-compatible, therefore it should suffice to code ~=2.31 meaning >=2.31, ==2.*.

tillsteinbach commented 3 weeks ago

Released in 0.60.3