search

tillsteinbach / WeConnect-python

Python API for the Volkswagen WeConnect Services
MIT License
109 stars 29 forks source link

Add proxy support #83

Closed towe96 closed 1 year ago

towe96 commented 1 year ago

Hi! First contribution to FOSS in a while, so mit Git may be a bit rusty.

I wanted to get the API running behind my companies proxy system so I added an optional proxy string to the API that will use the session.proxies.update method to set the proxy adresses of both the main session as well as the "websession" that's used in the doWebAuth methods. It seems to work well for me so far (starting / stopping / checking climatization of my e-Up), so I chose to share it.

It's my first time working with an "online" project, so perhaps there would've been an easier way to implement this.

tillsteinbach commented 1 year ago

Thank you for your nice contribution that I would like to include. Could you fix the two linter errors that are reported by the pipeline? Then I can merge your PR.

tillsteinbach commented 1 year ago

Great, thanks! I will prepare a new release with your contribution as soon as possible.