tilltnet / egor

R Package for importing and analysing ego-centered-network data.
http://egor.tillt.net
GNU Affero General Public License v3.0
23 stars 4 forks source link

Should we rename `as.egor` to `as_egor`? #60

Closed tilltnet closed 3 years ago

tilltnet commented 3 years ago

57 made be aware of the inconsistency of having as.egor() while all other similar functions are as_*. Are there any objections to renaming as.egor() to as_egor()?

krivit commented 3 years ago

Well, the base R convention is as., but Tidyverse is all about as_, so I can see the case either way.

tilltnet commented 3 years ago

Revisiting this I do now think we should stick with the dot for the as*() functions.