search

tilltue / TLPhotoPicker

📷 multiple phassets picker for iOS lib. like a facebook
MIT License
1.89k stars 332 forks source link

Unable to localize strings #326

Closed sroymeetup closed 3 years ago

sroymeetup commented 3 years ago

Version 2.1.5 breaks the ability to provide custom localizations to TLPhotosPickerConfigure.

I see that you localized the strings, but the list of built-in languages doesn't match the languages we need in our app. Previously we were able to provide the strings we wanted. Now TLPhotosPickerConfigure appears to load strings from its bundle and I don't see a way around it.

A solution would be to keep the old properties, and just localize the defaults.

public var tapHereToChange = NSLocalizedString("Tap here to change", bundle: Bundle(for: Self.self), comment: "")

(As someone else pointed out, this is an API change so shouldn't be a mere maintainance version bump. This broke our build.)

baronha commented 3 years ago

+1

tilltue commented 3 years ago

I think it should work now. I've pushed a fix for this. v2.1.6 revert #320

sroymeetup commented 3 years ago

Thank you!