tilly111 / adaptive_symmetry_breaking

0 stars 0 forks source link

Cross-inhibition is wrongly handled in some cases #6

Closed joefresna closed 2 years ago

joefresna commented 2 years ago

https://github.com/tilly111/adaptive_symmetry_breaking/blob/37462fabfa4e59c126882d5df72532a8c9241dac/ARGoS_simulation/behaviours/agent_stub.c#L336

Here the code should be revised.

I'd first check if I am COMMITTED or UNCOMMITTED. In the former case, my state should always become UNCOMMITTED, regardless of whether I have some memory or not.

Instead, in the current code, I think this does not happen.

I would reverse the order of the ifs. First check what will be my next state, then check if I need to save or recover some information from the 'memory'.

This is my understanding and suggestion, but please tell me if I missed something.

tilly111 commented 2 years ago

fixed.