search

tilmanginzel / alfred-bluetooth-workflow

Yet another Alfred workflow to connect / disconnect Bluetooth devices
MIT License
189 stars 8 forks source link

feat: add `blt-restart` command to restart Bluetooth #19

Closed jdbruijn closed 3 years ago

jdbruijn commented 3 years ago

Closes #18.

A couple of things about this PR.

  1. Note that I've re-used the blt-on and blt-off scripts to restart. I felt like that was a nice way to implement this command and not repeat the same code.
  2. I've added a 0.5s delay between turning the Bluetooth off and on again to get a better user experience. See the screen recording in Screen Recording 2020-10-12 at 19.11.36.mov.zip.
  3. I haven't updated the example screenshots in the readme because I don't seem to have the same theme as used in the current examples.
  4. I'm not sure about all changes in info.plist, for example argumenttreatemptyqueryasnil. I think some changes might have to do with a different Alfred version (I'm on 4.1.1 [1172]).
tilmanginzel commented 3 years ago

This was fast, thanks a lot @jdbruijn! :) Looks good on a first impression. I am still on vacation for the coming days, but will merge and release it later this week. I can then also check regarding the info.plist changes and will update the screenshots accordingly.

tilmanginzel commented 3 years ago

@jdbruijn Merged and released as v0.9.0, thanks again! :)

The only breaking info.plist change was the version change from 2 to 3, so I reverted that one.

jdbruijn commented 3 years ago

The only breaking info.plist change was the version change from 2 to 3, so I reverted that one.

Thanks! I wasn't sure about the plist so good thing I mentioned it. I've got Alfred 4 so can't easily test with other versions.

@tilmanginzel Thank you for releasing this right away, highly appreciated!

I'm going to archive my https://github.com/vidavidorra/alfred-bluetooth-control repo and would like to mention your workflow as a good replacement. Is that okay with you?

tilmanginzel commented 3 years ago

Yes of course, that's fine with me. 👍