search

tilmantroester / pyhmcode

Augmented halo model for accurate non-linear matter power spectrum calculations
MIT License
4 stars 4 forks source link

HMcode-2020 feedback issue #4

Closed alexander-mead closed 11 months ago

alexander-mead commented 1 year ago

There was a small problem with the predictions from the HMcode-2020 feedback model at very low k. These are described here: https://github.com/cmbant/CAMB/issues/135. HMcode-2020 with feedback would erroneously predict ~10% level effects on the power at k ~ 1e-4 h/Mpc.

I was able to fix these by changing the form of the one-halo term at large scales, which goes into the HMcode prediction for feedback, which is modelled as a response. The change can be seen here:

Before: before

After: after

You will need to pull the latest version of my Fortran library to have access to this fix, and also change the halo model corresponding to HMcode-2020 feedback from HMcode2020_feedback (number 103 in my numbering convention) to HMcode2020_feedback_lowkfix (number 141).

sjoudaki commented 1 year ago

@alexander-mead This is a really nice fix! @tilmantroester It seems having this included in pyhmcode would also be useful for the nonlinear task force in Euclid.

tilmantroester commented 1 year ago

I'm happy to accept pull requests ;)

alexander-mead commented 1 year ago

Ha! I can probably do this next week.

tilmantroester commented 11 months ago

This should now be covered with #9