tilt-dev / starlark-lsp

Starlark LSP server
Apache License 2.0
31 stars 5 forks source link

feat: Allow space inside argument defenition #47

Closed cutecutecat closed 1 year ago

cutecutecat commented 1 year ago

https://github.com/tilt-dev/starlark-lsp/blob/49955f646631551720ef540e4bac9c47f7ad16be/pkg/docstring/docstring.go#L391

starlark-lsp use LUCI docstring parser. Wheile parse an arg line, it doesn't allow any space inside argument, though it might be useful for add some type defenitions.

Examples: image

We could revised it into ^(\S.*?)\s*:\s*(.*)$, then could support more flexible argument defenition.

image

Related issue: https://github.com/tensorchord/envd/issues/1468

If you think this feature is acceptable, I would be happy to work on it.

nicksieger commented 1 year ago

No problem, go for it!