search

tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
204 stars 162 forks source link

double quotes in extracted local registry -> Error from server (BadRequest): Invalid JSON Patch #441

Closed asafamr closed 2 years ago

asafamr commented 2 years ago

In ubuntu microk8s patching configmap/config-deployment with local registry failed. The Tilt console showed a double quote after substituting $REGISTRY inside the patch command

this fixed the issue in my machine

nicks commented 2 years ago

LGTM, can you git rebase HEAD~1 --signoff to make the DCO bot happy? https://github.com/tilt-dev/tilt-extensions/pull/441/checks?check_run_id=7821696770

asafamr commented 2 years ago

done. BTW I had to manually install a knative network provider (Kourier) before kservices started deploying. not sure if it's specific to my env or something has changed in Knative