search

tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
204 stars 162 forks source link

Support OCI helm registries #458

Closed threesquared closed 1 year ago

threesquared commented 1 year ago

This PR introduces support for OCI registries like ECR to the helm_remote plugin. This fixes #457

The only changes needed are to allow urls in the repo_name field and replace helm search with helm show.

https://helm.sh/docs/topics/registries/

Example:

helm_remote(
    'chart-name',
    repo_name='oci://835442211234.dkr.ecr.eu-west-1.amazonaws.com',
    release_name='my-namespace',
    values=['{}/values.yaml'.format(os.path.dirname(__file__))],
  )
nicks commented 1 year ago

looks like this PR introduces a bug, which the tests caught. can you investigate?

threesquared commented 1 year ago

@nicks I am a little confused about this as it seems like memcached server comes up and the stats command is run with the expected output but then there is an ERROR but not sure how my changes could have introduced this as they are only to do with pulling the chart?

glehmann commented 1 year ago

thanks!

It's always nice to see that the change I thought I would have to code is already done and merged :+1: