It seems to have some issues that I wasn't having before as it worked correctly for me, as it is currently not working I modified it to have a dumbed down version of it working (without checks on pods/containers....)
I'm not sure why the past 1-2~ weeks was working for me and suddenly I'm not able to have it working again 🙃 (I do wonder if was a special state in my machine) and I guess that's why having the ci tests would have been a good idea!
It will need more work to figure out that I currently won't be able to dedicate due to vacations so please either accept the dumbed down version as it works (tested again from scratch, no possibility of specifying a container nor it will check before that it exists, if you missplace the name it will fail when run) or please do rollback the merge of that pr until I can get a better look at it!
nicks
commented
1 year ago
I've tried on a project again the newly merged:
It seems to have some issues that I wasn't having before as it worked correctly for me, as it is currently not working I modified it to have a dumbed down version of it working (without checks on pods/containers....) I'm not sure why the past 1-2~ weeks was working for me and suddenly I'm not able to have it working again 🙃 (I do wonder if was a special state in my machine) and I guess that's why having the ci tests would have been a good idea!
It will need more work to figure out that I currently won't be able to dedicate due to vacations so please either accept the dumbed down version as it works (tested again from scratch, no possibility of specifying a container nor it will check before that it exists, if you missplace the name it will fail when run) or please do rollback the merge of that pr until I can get a better look at it!
Thank you and sorry 🙇♂️ @nicks