search

tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
204 stars 162 forks source link

[Feature] Add rsync tilt path #479

Closed coler-j closed 1 year ago

coler-j commented 1 year ago

Adds functionality to customize the rsync path on the container to resolve potential permission errors if the execution user does not have permission to modify the containers /bin directory. Resolves https://github.com/tilt-dev/tilt-extensions/issues/478

Adds the tilt_rsync_path parameter to the syncback command.

Used like:

syncback("python-syncback", 
    "deploy/syncback-containers", 
    "/root/", 
    paths=['main.py'],  
    target_dir=python, 
    container="python", 
    namespace="syncback-test",
    rsync_path="/some/remote/path/"
)
nicksieger commented 1 year ago

Ugh, I'm sorry, it looks like GH suggestions don't add Signed-off-by: to the commits. Would you mind just squashing them all, ensuring you have sign off, and do a git push --force-with-lease to your PR branch?

coler-j commented 1 year ago

@nicksieger I have to run to an appointment, but will clean this up first thing tomorrow AM (EST)

coler-j commented 1 year ago

@nicksieger does that work?

nicksieger commented 1 year ago

Thanks for the improvement!

coler-j commented 1 year ago

Thanks @nicksieger how long until this change is released / useable?