search

tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
201 stars 159 forks source link

added decoding for special characters in git branch names #496

Closed MathiasAugstein closed 1 year ago

MathiasAugstein commented 1 year ago

We are using branch names containing #, hence the missing possibility to encode these characters is a problem for us. I propose this change, which lets the user use encoded special characters for the two characters used to split the branch name from the repo name.

Does this need to be documented in the Readme, or can we trust that smart software developers try encoding the characters according to standard URL encoding rules?

nicks commented 1 year ago

thanks for the report! posted https://github.com/tilt-dev/tilt-extensions/pull/497 as an alternative

nicks commented 1 year ago

actually, i changed my mind, i like this pr better. can you add a test case for it under ./test?

MathiasAugstein commented 1 year ago

Test cases added. Also decided to add one sentence to the Readme. In case you do not like it I can remove the Readme-Commit.

Anyway, I am glad to solve my problem and contribute to the project. My first time pushing code to an open source repo. :)