search

tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
201 stars 159 forks source link

fix(helm_resource): no parallel in `helm_repo` #501

Closed nschmeller closed 1 year ago

nschmeller commented 1 year ago

Multiple invocations of helm_repo may not be concurrency safe because of the execution of helm repo add. This commit unsets the allow_parallel argument in helm_repo to prevent this bug.

Resolves #500

nicks commented 1 year ago

hmmmm....i played around with this a bit. i'm not so sure this is the problem. helm repo add seems pretty thread-safe to me, and is using a file lock - https://github.com/helm/helm/blob/main/cmd/helm/repo_add.go#L125

are you sure this isn't just a mix-up with resource_deps? i.e., the ci run that you were looking at didn't have resource_deps setup? how often are you seeing this happen?

nschmeller commented 1 year ago

are you sure this isn't just a mix-up with resource_deps? i.e., the ci run that you were looking at didn't have resource_deps setup? how often are you seeing this happen?

Just the once, but I'm pretty sure the Tiltfile definition was correct (or at least tilt ci had worked on a clean setup before and after). Maybe I'll drop this for now and if I see it again then re-raise it?

nicks commented 1 year ago

hmmm very mysterious. ya, let's close for now. we can re-evaluate if we see it again and try to pin down a repro case.