Closed nschmeller closed 1 year ago
hmmmm....i played around with this a bit. i'm not so sure this is the problem. helm repo add
seems pretty thread-safe to me, and is using a file lock - https://github.com/helm/helm/blob/main/cmd/helm/repo_add.go#L125
are you sure this isn't just a mix-up with resource_deps? i.e., the ci run that you were looking at didn't have resource_deps setup? how often are you seeing this happen?
are you sure this isn't just a mix-up with resource_deps? i.e., the ci run that you were looking at didn't have resource_deps setup? how often are you seeing this happen?
Just the once, but I'm pretty sure the Tiltfile definition was correct (or at least tilt ci
had worked on a clean setup before and after). Maybe I'll drop this for now and if I see it again then re-raise it?
hmmm very mysterious. ya, let's close for now. we can re-evaluate if we see it again and try to pin down a repro case.
Multiple invocations of
helm_repo
may not be concurrency safe because of the execution ofhelm repo add
. This commit unsets theallow_parallel
argument inhelm_repo
to prevent this bug.Resolves #500