tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
201 stars 159 forks source link

helm_remote not using provided namespace #506

Closed jtinspire closed 1 year ago

jtinspire commented 1 year ago

helm_remote is not respecting the parameter provided for 'namespace'. The deployment keep happening to default namespace. Example :

load('ext://helm_remote', 'helm_remote')

k8s_yaml(
    helm_remote(
        'postgres',
        namespace='jaytripathi',
        repo_name='postgres',
        repo_url='https://romanow.github.io/helm-charts/',
    ),
    allow_duplicates=True
)
nicks commented 1 year ago

do you know if this is a recent regression?

abdulvirta commented 1 year ago

Yes this seems to be a very recent regression as of this morning. Might be related to this change that went 5 hours ago. https://github.com/tilt-dev/tilt-extensions/blob/master/helm_remote/Tiltfile

abdulvirta commented 1 year ago

Btw, is helm_resource preferred to use instead of helm_remote? should we switch to helm_resource? and just wondering what is the main difference and why helm_resources is preferred?

jtinspire commented 1 year ago

Sorry late to respond. But this is resolved now with above revert.

abdulvirta commented 1 year ago

Thanks! Just a general question, which one is more recommended to use helm_resource or helm_remote? just trying to figure out which one is more supported and if there are any differences?