fix(min_k8s_version): Remove --short flag for kubectl version - Githubissues

tilt-dev / tilt-extensions

Extensions for Tilt

https://tilt.dev/

Apache License 2.0

201 stars 159 forks source link

fix(min_k8s_version): Remove --short flag for kubectl version #520

Closed hiohiohio closed 1 year ago

hiohiohio commented 1 year ago

Context:

kubectl deprecated --short flag for kubectl version at v1.24 https://github.com/kubernetes/kubernetes/pull/108987
kubectl removed --short flag for kubectl version at v1.28 https://github.com/kubernetes/kubernetes/pull/116720
currently we have an error in the below with kubectl v1.28
default output is changed as same as --short flag

Error in local: command "kubectl version --short" failed.
error: exit status 1
stdout: ""
stderr: "error: unknown flag: --short\nSee 'kubectl version --help' for usage.\n"

Changes:

removed --short flag for kubectl version in min_k8s_version
min_k8s_version requires kubectl v1.28+

nicks commented 1 year ago

Thanks! I'm going to close this as duplicating https://github.com/tilt-dev/tilt-extensions/pull/521, which handles backwards compatibility a little better