search

tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
201 stars 159 forks source link

Setting working directory of `cmd_button` #526

Closed Tadimsky closed 9 months ago

Tadimsky commented 1 year ago

I'm using multiple Tiltfiles for multi-repo scenario. I run tilt up in the main service which conditionally includes the Tiltfile from other repos.

In one of the other repos, I'm using cmd_button but it is failing as it runs the command in the working directory of where tilt up was called. I am running commands like yarn graphql-codegen that rely on files in the ./node_modules file of the other repo.

Is there a way to set the working directory of a cmd_button so that it operates either where the Tiltfile is that defined it (the other repo) or for us to explicitly set it as a relative path?

nicks commented 1 year ago

not currently, but we would accept a pr to take the dir as an argument

nicks commented 9 months ago

this got fixed in https://github.com/tilt-dev/tilt-extensions/pull/532