tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
201 stars 159 forks source link

helm_repo not defining correct resource_name #536

Closed diogobaeder closed 9 months ago

diogobaeder commented 9 months ago

Hi guys,

When using helm_repo, from the helm_resource extension, the documentation says that it defaults to helm-[name], however the code doesn't do that - instead, it defaults to just using the name directly - here's the offending code: https://github.com/tilt-dev/tilt-extensions/blob/master/helm_resource/Tiltfile#L157-L158

I found this because trying to define a helm_resource right after a helm_repo without explicitly defining the repo resource name just fails, because the resource name of the helm_resource ends up conflicting with the helm_repo one.

Cheers!