tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
201 stars 159 forks source link

add base64 and dict_merge extension #538

Closed gebinic closed 7 months ago

gebinic commented 9 months ago

Added an extension which encodes and decodes a string. Supported unix and windows systems.

EDIT: add dict_merge extension

nicks commented 9 months ago

thanks for the contribution!

i'm fine with the base64 extension

i'm nervous about having the dict_merge extension in the main extensions repo, because:

gebinic commented 9 months ago

We distinguish between deploy_config.yml ("global" configuration file) and local_config.yml (git ignored file, only local user configuration file). Due to our configuration model, it is extremely difficult to merge these configuration files manually, among other things with the dictionary union operator. Therefore, we decided to introduce the dict_merge function, which simply merges all configurations deeply. I think this could be a use case that also affects other tilt users.

nicks commented 7 months ago

i think we'd accept a pr for just the base64 but wouldn't accept dict_merge, for the reasons stated above. closing this pr, but feel free to repopen for the base64 part