search

tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
200 stars 156 forks source link

custom_build_with_restart dosnt work for env and dir params #558

Closed cm226 closed 5 months ago

cm226 commented 5 months ago

I was calling custom_build and using the "div" and "env" paramaters. Once I swapped to calling custom_build_with_restart I got the following errors:

Error in docker_build: docker_build: unexpected keyword argument "dir"

Expected Behavior no error

I managed to fix it by adding "env" and "dir" to _CUSTOM_BUILD_KWARGS_BLACKLIST. Which I guess is the right thing to do?

_CUSTOM_BUILD_KWARGS_BLACKLIST = [ 'tag', 'command_bat', 'outputs_image_ref_to', 'disable_push', 'dir', 'env' ]