search

tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
200 stars 156 forks source link

Add rsync_options parameter to syncback #568

Closed pedantic-git closed 4 months ago

pedantic-git commented 4 months ago

This adds a parameter to the syncback extension that allows specifying of any rsync options for more advanced usage. Right now I'm using it to work around #567 with the following code:

syncback('sync lockfiles', 'deploy/name-pn', '/rails/', 
  rsync_options=[
    '--include=db/', '--include=db/schema.rb',
    '--include=Gemfile.lock', '--include=yarn.lock', '--exclude=*'
  ]
)

but I imagine it could be used for all kinds of other advanced usage. I'm still up for attempting to write the more user-friendly solution to #567 if that's of interest too.

nicksieger commented 4 months ago

Works for me, thanks! Can you re-push a commit with a Signed-off-by: Name <email@domain.com> line in the message to satisfy the DCO check?

pedantic-git commented 4 months ago

Ooh sorry for missing that! I've re-pushed with that signoff.