search

tilt-dev / tilt-extensions

Extensions for Tilt
https://tilt.dev/
Apache License 2.0
200 stars 156 forks source link

Forward signals in restart wrapper #583

Closed jscheel closed 2 months ago

jscheel commented 3 months ago

This PR fixes #577 by forwarding signals from the tilt-restart-wrapper to the entrypoint that is wrapped.

tmc commented 2 months ago

Just on ping here, as this would be helpful.

jscheel commented 2 months ago

Sorry, I’m traveling in Vietnam right now. I can fix up in a couple of min as soon as I get back.

On Wed, Jun 5, 2024 at 5:55 AM Travis Cline @.***> wrote:

Just on ping here, as this would be helpful.

— Reply to this email directly, view it on GitHub https://github.com/tilt-dev/tilt-extensions/pull/583#issuecomment-2148546150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABTUFVFTBQPXHPCIPHV7PLZFZAXJAVCNFSM6AAAAABHP3IV7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYGU2DMMJVGA . You are receiving this because you authored the thread.Message ID: @.***>

tmc commented 2 months ago

I pushed a set of improvements here: https://github.com/tmc/tilt-extensions/tree/forward-signals-in-restart-wrapper

nicks commented 2 months ago

merged this as https://github.com/tilt-dev/tilt-extensions/pull/586