tilt-dev / tilt

Define your dev environment as code. For microservice apps on Kubernetes.
https://tilt.dev/
Apache License 2.0
7.58k stars 298 forks source link

Tilt LSP Tree-Sitter support #5853

Open Davincible opened 2 years ago

Davincible commented 2 years ago

Is it correct that the LSP currently has no Tree-Sitter syntax highlighting support? If so I'd like to request the implementation of Tree-Sitter syntax highlighting

I read over https://github.com/tilt-dev/tilt.specs/blob/master/ide_extensions.md and it seems to be on the radar, however after setting up the LSP server in neovim https://github.com/neovim/nvim-lspconfig/pull/1941 I only have completion, but no syntax highlighting.

nicksieger commented 2 years ago

Thanks for the suggestion! That's right, we only have the TextMate definitions for syntax highlighting at the moment.

How has the LSP stuff worked for you in NeoVim otherwise?

Davincible commented 2 years ago

The auto-completion works like a charm; image

I managed to get some syntax highlighting by setting set syntax=python I also just noticed that (Neovim) treesitter has no Starlark support (yet), so adding Tilt LSP Treesitter support wouldn't directly help me.

https://github.com/nvim-treesitter/nvim-treesitter#supported-languages

Python syntax highlighting works fine for me so far, and is a lot nicer to work with than no syntax highlighting