search

tilt-dev / tilt

Define your dev environment as code. For microservice apps on Kubernetes.
https://tilt.dev/
Apache License 2.0
7.6k stars 299 forks source link

feat: update product name prefix for microk8s cluster #6374

Closed pmarchini closed 4 months ago

pmarchini commented 4 months ago

Updated microk8s to support cluster names starting with microk8s, resolving issue #4300.

nicks commented 4 months ago

thanks! but you need to update https://github.com/tilt-dev/clusterid, or this will just get reverted next time we vendor

pmarchini commented 4 months ago

@nicks thanks for the hint, I was also taking a look at the source looking for function tests without any success, going to open a PR from the correct repo( this time adding also tests) 😁

pmarchini commented 4 months ago

thanks! but you need to update https://github.com/tilt-dev/clusterid, or this will just get reverted next time we vendor

@nicks I moved the changes to the right repo and opened a new PR