search

tilt-dev / tilt

Define your dev environment as code. For microservice apps on Kubernetes.
https://tilt.dev/
Apache License 2.0
7.6k stars 299 forks source link

tty in local_resource kills tilt #6378

Closed nicks closed 3 months ago

nicks commented 4 months ago

Steps to Reproduce

Tiltfile:

local_resource('test', ['./test.sh'])

test.sh:

#!/bin/bash

zsh -i -l -c 'exit;'

1) Run tilt up and wait a little while 2) Hit space

Expected Behavior

Tilt should successfully run the command

Current Behavior

On macOS, tilt crashes with suspended (tty input) On Linux, the terminal gets mysteriously detached from the tilt process

nicks commented 4 months ago

i was able to get something working by attaching a pty to stdin of the process...

i'm not sure if that's a good general solution (since some stuff may behave differently when it's interacting with a pty) but i guess we can make it an option

nicks commented 4 months ago

the pr was rolled back