tiltshiftnl / mini-crm

Mini-CRM for the Amsterdam Servicecentrum Onderwijs
0 stars 1 forks source link

Search button in searchbar doesn't work #32

Closed milovanderlinden closed 3 years ago

milovanderlinden commented 3 years ago

search button in searchbar has no function

milovanderlinden commented 3 years ago

It is part of the component created by the city of Amsterdam in their style. Please address the issue there, or hand me a solution on how to handle the click.

milovanderlinden commented 3 years ago

See https://github.com/Amsterdam/amsterdam-styled-components/blob/master/packages/asc-ui/src/components/SearchBar/SearchBar.tsx

As is shown in the piece of code, there is no way to style the button, turn it off, or change the icon to f.i. a filter icon.

<Button
        aria-label={placeholder || 'Zoek'}
        title={placeholder || 'Zoek'}
        type="submit"
        size={36}
        onClick={handleOnSubmit}
        variant="secondary"
      >
        <Icon size={20}>
          <Search />
        </Icon>
      </Button>
milovanderlinden commented 3 years ago

For now, I decided to overrule the style.

milovanderlinden commented 3 years ago

That doesn't work because the button class is altered by the react release pipeline. Will try to set a class on the main object and see if it trickles down.