tilwinjoy / angular-bootstrap-material

AngularJS directives for bootstrap material design components
http://tilwinjoy.github.io/angular-bootstrap-material
21 stars 13 forks source link

General discussion #3

Open tilwinjoy opened 8 years ago

tilwinjoy commented 8 years ago

^What the title says.

amanagrawal9 commented 8 years ago

Does it have the round responsive buttons ?

tilwinjoy commented 8 years ago

@amanagrawal9 If you meant the floating action buttons of bootstrap material design, Yes it should, just like other buttons since there is no additional functionality apart from CSS change.

amanagrawal9 commented 8 years ago

Yes but i didn't see it at demo page.

tilwinjoy commented 8 years ago

@amanagrawal9 Only additional thing this project requires is the directive abmComponent for the ripple effect on most of the components other than form controls.

I thought it's pointless to copy paste all the verities of buttons like flat disabled buttons, raised disabled buttons, block level buttons, fab buttons, button groups so and so since all of that is a CSS thing and it's documented in bootstrap material design. So I've added a link in the documentation pointing to bootstrap material design doc for different types of buttons.

RudineyMejias commented 8 years ago

Hello, I was trying this module. It's pretty fine, but I found two issues. The first one, when you are using inputs with floating labels and you add some default text with ngModel, the label overlaps the text until you modify the input value. The other issue is that I'm not able to add an input text with prefix icon.

tilwinjoy commented 8 years ago

@RudineyMejias Thanks for the info. I had fixed the first issue you mentioned. I guess I forgot to push it. Will take care of that.

But I didn't get what you meant by input text with prefix icon. Are you referring to input group? BTW if you actually find a bug feel free to open an issue so that we can track it separately, also it'll give me something to start with.

tilwinjoy commented 8 years ago

@RudineyMejias I have pushed the fix for label overlapping issue. Here's a JSFiddle Demo. Let me know if there is any issue.

antonioaltamura commented 8 years ago

Hi, how much this project is far from be 'production ready'? There are unsolved known bugs? I see <select> not completely in material, the dropdown in navbar doesn't shows..

tilwinjoy commented 8 years ago

@antonioaltamura as mentioned in README this project does not handle CSS. If you think <select> doesn't follow material guidelines, please report in Bootstrap Material Design project according to guidelines.

Dropdown and navbar works fine in the Project page's actual navbar itself (dropdowns inside navbar demo doesn't work because it's just a demo of navbar, not dropdown. Maybe I should update that demo). If you find an issue related to this project please report according to Contribution guidelines.

P.S:

how much this project is far from be 'production ready'? There are unsolved known bugs?

I believe you're asking this because of the work in progress note. I left it there since the ripple effect (animation) for pagination and pager is not yet added. Because their material implementation is not yet included in Bootstrap Material Design and I never had to use them so far.
You can visit the Issue tracker to check if there are unsolved known bugs. As of now there are none.

frederikprijck commented 8 years ago

Any plans on allowing us to install throughout npm ?

Cojomax99 commented 8 years ago

The navbar-brand element on your github.io page says "bootsrap" instead of "bootstrap"! 😄

tilwinjoy commented 7 years ago

@Cojomax99 Good catch 😊