tim-balloon / TIMflight

Flight MCP repo
0 stars 0 forks source link

Star camera computers not getting commands when sending LAT/LON/ALT enabled #104

Closed evanmayer closed 1 month ago

evanmayer commented 1 month ago

Describe the bug When flight computers are configured to send star cameras lat/lon info for use in their solutions, it seems that mcp is unable to command them to do updates like exposure time, aperture, etc.

To Reproduce Steps to reproduce the behavior:

  1. Start an FC running mcp and a SCC on the same network running the star camera software
  2. Start a ground station running groundhog, guaca, kst2, and cow, to send commands to the star camera computer via mcp
  3. Send command to change exposure time
  4. See exposure time remain the same in telemetry

Expected behavior When commanded to change exposure time or any other parameters, SCC reports change back to FC, then to GSE via telemetry.

Screenshots If applicable, add screenshots to help explain your problem.

Environment info (please complete the following information):

Additional context The SCCs do and report on what they have been commanded to do based on flags they unpack from the command packet sent by mcp. Ian surmises that the packet is improperly written somehow and either stomps on the flags or clears the fields prematurely.

Start looking in mcp/sensors/star_camera_transmit.c:prepare_command_packet_*

evanmayer commented 1 month ago

Closed after debugging software on both machines with a network switch in between, and commands sent from a laptop running blastcmd Evidently, the code does work, and we saw the star camera computer updating the intended parameters.