search

tim-balloon / TIMflight

Flight MCP repo
0 stars 0 forks source link

check pilot.c and highrate.c for duplicate/common functionality #6

Open evanmayer opened 2 years ago

evanmayer commented 2 years ago

Task

Skimming ./mcp/communications/pilot.c and ./mcp/communications/highrate.c revealed code that is similar in *_compress_and_send(), despite not being picked up by similarity analysis tools. This suggests it is a candidate for refactoring to reduce duplicate code. Determine if the similarity is sufficient to functionalize the similar parts.

Acceptance

If not similar enough to make a neat refactored function, the issue is closed. If it seems tenable, make a new follow-on issue to encompass the effort.

Details

Treat this issue as a "spike," if you know what that is. Don't spend longer than a day on it.

evanmayer commented 1 year ago

Possible synergy with EVTM overhaul - if all non-pilot TM outputs will now be sent to multicast addresses rather than packetized and sent in a bespoke manner, there will be even more duplicate code, and more reason to reduce it.

evanmayer commented 1 year ago

60