Function responsible for estimating the azimuth and the elevation, PSSConvert, is fairly large and contains a few magic numbers. In order to make it easier to follow and cover with unit tests it should be refactored which may include splitting it into smaller, more manageable pieces.
Acceptance
Magic numbers should be replaced by symbolic constants or at least well documented (if using a symbolic constants seems like an overkill).
New function(s) must be covered by unit tests.
Details
See:
Gandilo, N., PROBING INTERSTELLAR GRAIN ALIGNMENT WITH BALLOON - BORNE SUBMILLIMETER OBSERVATIONS [Phd Thesis, University of Toronto, 2015]
Williams, P. A., MAPPING GALACTIC CLOUDS WITH THE BALLOON-BORNE LARGE APERTURE SUBMILLIMETER TELESCOPE (BLAST) [PhD Thesis, Northwestern University, 2021]
for more details regarding architecture and usage of the pihhole sun sensors.
Task
Function responsible for estimating the azimuth and the elevation,
PSSConvert, is fairly large and contains a few magic numbers. In order to make it easier to follow and cover with unit tests it should be refactored which may include splitting it into smaller, more manageable pieces.Acceptance
Details
See:
for more details regarding architecture and usage of the pihhole sun sensors.