tim-elmer / feminine-female-farmer

Alex_01's farmer sprite overhaul, updated to work with Content Patcher and newer versions of SDV.
MIT License
1 stars 0 forks source link

Arms are weird #4

Open rachelleeann opened 1 year ago

rachelleeann commented 1 year ago

When you update your characters hair using the mirror from fashion sense the arms stick out through the hair, meaning you can see the arms from behind

tim-elmer commented 1 year ago

Interesting. Does the issue persist when you leave the mirror UI? Can you provide a screenshot (I don't play with this mod enabled, or with Fashion Sense)?

rachelleeann commented 1 year ago

Before Screenshot 3_9_2023 9_28_09 PM After image After running image In mirror (Fashion Sense) image

tim-elmer commented 1 year ago

Hmm. Unfortunately I think this may be related to how Fashion Sense works its magic. As this mod is just a Content Patcher patch, I don't think there's much - if anything - that I can do.

Does the issue persist after restarting the game?

rachelleeann commented 1 year ago

So I player tested a bit more and it seems like the mod isn't registering that there's still hair on the sprite. It only looks bad when I apply long hair.

There's another mod very similar to this one on Nexus, More Elegant Farmer Body, that works with FS. Makes me hope that this one could, too

tim-elmer commented 1 year ago

The thing is, this mod doesn't "know" anything about hair. All this mod (and by extension Content Patcher) does is edit the sprite sheet being loaded for the player base and shirts. That said, it shouldn't be rendering over the hair regardless. It's possible that the way I am loading the sprite sheet is causing compatibility issues with something else you have installed.

I can't quite reproduce the issue (using Fashion Sense and Shardust's Animated Hairstyles [I believe that's what you're using]) either way:

image image

That said, I switched to editing the sheet rather than loading a new image. Does this work how you expect it to? feminine-female-farmer_edit-body-test.zip

rachelleeann commented 1 year ago

I'll check that out when I get the chance, I've been using the mod anyways because I figured I could either NOT change the hair or just use the short styles. But somehow, because I haven't changed anything, the mod is working fine. Any hair, short or long, it's fine. Super weird.

rachelleeann commented 1 year ago

I just had a thought, Fashion Sense updated today, I wonder if there was a fix??

tim-elmer commented 1 year ago

That's entirely possible, I just grabbed the latest version. 🤷‍♂️

tim-elmer commented 1 year ago

Completely unrelated; lovely farmhouse! :)

rachelleeann commented 1 year ago

image

Screenshot of my log with your test file loaded

tim-elmer commented 1 year ago

Ah. I seem to have left a bunch of extra space on the right side from some of FFF's legacy sprite indices. Not sure why you got an error message and I didn't, but this should fix it. feminine-female-farmer_math-is-hard.zip

rachelleeann commented 1 year ago

Sadly it didn't work. But once you change the clothes the arms go back to normal. I'm gonna play with the mod either way lol, so thank you for the work you've put into it. ALSO, the farm house is: https://www.nexusmods.com/stardewvalley/mods/14411

Sidenote, do you know if this mod is multiplayer compatible?

tim-elmer commented 1 year ago

It should be, cosmetic mods will work just fine in multiplayer, but will only be visible for those using them.

rachelleeann commented 1 year ago

image Come across this in the items menu, seems I'm missing quite a few base game shirts. Do you have any ideas how I could fix this? I'm fairly certain it's cause of the body mod

tim-elmer commented 1 year ago

Does the same thing happen with this mod disabled?

rachelleeann commented 1 year ago

No, it doesn't. Just checked. I'm also not running any other mods that change base game clothes.

tim-elmer commented 1 year ago

Yeah, thinking about it more, that makes sense. Because the original mod was created before the additional clothing items existed, there is just transparent space in those sprite indices. Unfortunately that's not something that I have the bandwidth to fix right now, as all of the vanilla shirt sprites not covered by the mod would need to be tweaked to fit.