search

tim-group / java-statsd-client

a java statsd client library
Other
275 stars 139 forks source link

add count metric type sample rate support #10

Closed cychenyin closed 10 years ago

cychenyin commented 11 years ago

remote final modifier of class NonBlockingStatsdClient and some fields

scarytom commented 10 years ago

Firstly, apologies for letting this go dormant for so long.

I'd like to enhance the java-statsd-client to support sample rates, but I'm not happy tying this to tangential changes like 98cfd02f24aa2c08ec7f9cc54246e52223550621, and, for that reason, I'm not going to merge this pull request.

If you re-submitted your pull request with a focussed set of changes, I would pull it, but, as I'm working on this codebase again, and I plan on adding support for sample rates soon, I don't think it is worth you doing this.

I will close this pull request once I've pushed my changes to support sample rates.