Test "createsFileSystemCodeBaseLocatorForEachJarPathGiven" is failed on Windows

[leonidv]

Operation system: Windows 7, test executed in cygwin (gitbash).

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.07 sec <<< FAILURE!
createsFileSystemCodeBaseLocatorForEachJarPathGiven(com.youdevise.fbplugins.tdd4fb.AuxCodeBaseLocatorProviderTest)  Time elapsed: 0.019 sec  <<< FAILURE!
java.lang.AssertionError: 
Expected: (a collection containing a FileSystemCodeBaseLocator with directory equal to "/some/path/to/myFirstJar.jar" and a collection containing a FileSystemCodeBaseLocator with directory equal to "/some/path/to/mySecondJar.jar" and a collection containing a FileSystemCodeBaseLocator with directory equal to "/some/path/to/myDirectory")
     got: <[filesystem:C:\some\path\to\myFirstJar.jar, filesystem:C:\some\path\to\mySecondJar.jar, filesystem:C:\some\path\to\myDirectory]>

[Grundlefleck]

Hi,

Thanks for raising. I don't have a Windows machine to test on, I've tried to change the test to be platform independent (with commit 15804c82979da531d65e58bb5610fea1c778eff7). Could you please pull from master and try again?

[leonidv]

Hi, thanks for quick response.

Test is failed, but with another error:

Expected: (a collection containing a FileSystemCodeBaseLocator with directory equal to "c:\Users\l.vygovsky\Documents\sources\test-driven-detectors4findbugs\path\to\myFirstJar.jar" and a collection containing a FileSystemCodeBaseLocator with directory equal to "c:\Users\l.vygovsky\Documents\sources\test-driven-detectors4findbugs\path\to\mySecondJar.jar" and a collection containing a FileSystemCodeBaseLocator with directory equal to "c:\Users\l.vygovsky\Documents\sources\test-driven-detectors4findbugs\path\to\myDirectory")
     got: <[filesystem:C:\Users\l.vygovsky\Documents\sources\test-driven-detectors4findbugs\path\to\myFirstJar.jar, filesystem:C:\Users\l.vygovsky\Documents\sources\test-driven-detectors4findbugs\path\to\mySecondJar.jar, filesystem:C:\Users\l.vygovsky\Documents\sources\test-driven-detectors4findbugs\path\to\myDirectory]>

[Grundlefleck]

Hi, would you be able to test the following suggestion:

https://github.com/youdevise/test-driven-detectors4findbugs/commit/15804c82979da531d65e58bb5610fea1c778eff7#commitcomment-3669149

Sorry the feedback cycle is a bit slow, hard to test without a Windows machine.

[Grundlefleck]

Hi @leonidv,

Did you get a chance to try the above suggestion?

[VsevolodGolovanov]

All tests pass successfully on Windows 7 (without cygwin) currently:

Running com.youdevise.fbplugins.tdd4fb.AuxCodeBaseLocatorProviderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.068 sec
Running com.youdevise.fbplugins.tdd4fb.DetectorAssertTest
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.814 sec
Running com.youdevise.fbplugins.tdd4fb.DetectorRunnerTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.389 sec
Running com.youdevise.fbplugins.tdd4fb.example.CustomClassNameLengthDetectorTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec
Running com.youdevise.fbplugins.tdd4fb.FailedInitialisationTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec
Running com.youdevise.fbplugins.tdd4fb.TestingBugReporterTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec