Support Detector2 interface

tim-group / test-driven-detectors4findbugs

Test-Driven Detectors For FindBugs. Utility project to ease the development of custom plugin detectors for FindBugs.

Other

17 stars 17 forks source link

Support Detector2 interface #8

Closed KengoTODA closed 11 years ago

KengoTODA commented 11 years ago

Hi ALL,

currently I want to use this library to test a FindBugs plugin which implements Detector2 interface. I can provide a patch for this issue, but this library looks inactive, so I am afraid that you will not check and merge it.

Can you review, merge my pull request and deploy new version into Maven central repository? If you can, I will send a patch for you (and this is the best plan for me). If you cannot, I will fork this library and try to deploy with another groupId.

Thanks in advance.

Grundlefleck commented 11 years ago

Hi eller86,

Apologies for not responding sooner. I do intend for this project to be active, and to respond to issues like this. I will need to check GitHub notification settings to figure out why I didn't receive an email.

I'll take a look at the pull request and update here.

Thanks!

KengoTODA commented 11 years ago

Thanks, I made #9 so please check it. When you find some problem, I will fix it ASAP. I hope you will merge it and publish new version onto Maven central later.

I know that many GitHub user cannot get notification, maybe GitHub has changed some implementation.

Grundlefleck commented 11 years ago

Hi @eller86

Just a heads up, I realised there was a typo in the method names. I wanted to fix this before releasing next version, but this will be a source incompatible change for you (hopefully trivial to fix though).