tim-hellhake / mi-flora-adapter

Mozilla Public License 2.0
1 stars 3 forks source link

add conductivity and brightness #11

Closed Beejeedeb closed 5 years ago

Beejeedeb commented 5 years ago

Hi Tim, Is it also possible to add conductivity (fertility of the soil) and brightness?

I found some more information about the mi Flora maybe something you can use in your code.

https://github.com/vrachieru/xiaomi-flower-care-api

tim-hellhake commented 5 years ago

I will definitely add this but it may take a few days. I'll get back to you.

tim-hellhake commented 5 years ago

I finally found time to do this. The values look plausible, but the brightness property looks a bit strange. I'm not sure why this is happening. I have to analyze this further.

Beejeedeb commented 5 years ago

I will check the update if it is available and see if I can find somemore information

Beejeedeb commented 5 years ago

isnt there a difference between brightness of a light bulb which can be changed with a slider and illuminance for light sensor? Different attributes and (level)properties. For this I think a normal luminance lux value should suffice.

tim-hellhake commented 5 years ago

Makes sense. There seems to be a fallback in the gateway which assumes that a property called brightness is always the brightness of a light bulb in percent. Renaming the property to illuminance should fix the issue.

tim-hellhake commented 5 years ago

The values of the light sensor should be displayed correctly now. If you have any problems please open an issue.