search

tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
225 stars 41 forks source link

Create proper 429 request limit error response #101

Closed brennenputh closed 5 months ago

brennenputh commented 1 year ago

The Problem

The error is unclear when this plugin hits a request limit.

Reproduction

Type --John1:1-3 in the editor, and then type a 0 at the end and delete it repeatedly. Eventually, the request will return a HTTP 429 status code, indicating it's hitting a rate limit. This is not shown to the user, however, and simply causes the suggester to stop updating.

Proposed Solution

Return the error in some way to the user - either by a notification popup or by replacing the content in the suggester with something relevant.

tim-hub commented 1 year ago

😢

tim-hub commented 1 year ago

a good idea

brennenputh commented 1 year ago

As a sidenote and addition - when I was looking for the cause of this, I had to replace the fetch in this line with requestUrl to get it to spit out a real error instead of a CORS error. Likely a good change to make, but too small for a PR to fix only that.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.