Add loading dialogue while waiting on API (Fixes #100)

tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.

https://antioch.tech/obsidian-bible-reference/

MIT License

225 stars 41 forks source link

Add loading dialogue while waiting on API (Fixes #100) #102

Closed brennenputh closed 1 year ago

brennenputh commented 1 year ago

Summary

Adds a div that shows until the Promise of the API results returns with results.
Styles that div.
- Fixes #100

Discussion

This requires use of Obsidian's internal API, which could change and break the plugin. I think this specific part is unlikely to change, however.

Style improvements welcome - I'm not good at CSS!

tim-hub commented 1 year ago

Hi @brennenputh

I like this idea, it is a good practice to have a waiting UI for it.

Do you have a screenshot or GIF/recording of how it will look like?

brennenputh commented 1 year ago

My bad @tim-hub. Attached is an image showing the container (I had to slow down my network to get to see it lol) Also, codeball seems to just be down, might be worth removing it from the repo altogether.