search

tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
225 stars 41 forks source link

Toggle Default Collapsed or Expanded #122

Closed minermaniac447 closed 1 year ago

minermaniac447 commented 1 year ago

Implements #111; currently, the default setting is "expanded" (true). This could be changed to "collapsed" (false) to match current implementation.

minermaniac447 commented 1 year ago
  1. The purpose of this plugin is to render verses directly, the old collapsable (close by default) breaks this purpose, which need to be fixed (Thanks this PR)

I somewhat agree, with the exception of mobile users - when inserting long passages (i.e. a whole chapter for some sermon topics), it can take up the majority, if not more than that, of the screen, which can get frustrating. For most desktop users and for small verses this isn't a problem but I do think having the option to insert small is a good idea

  1. There have been too many setting toggles, we should try not add more.

I agree that we have a lot of tagging ones but it seems like there are already changes in the works to deal with this; personally I'd always rather customizability over removing options. If you're adamant on this position, could I suggest a compromise of sorting the settings into collapsible toggles?

(I'll also note I did want to make this toggle only visible when collapsible was enabled in the first place but didn't yet know how to do that; that's a change that could be implemented in a few other places too too simplify things, as part of a potential UI update pr later)

tim-hub commented 1 year ago
  1. The purpose of this plugin is to render verses directly, the old collapsable (close by default) breaks this purpose, which need to be fixed (Thanks this PR)

I somewhat agree, with the exception of mobile users - when inserting long passages (i.e. a whole chapter for some sermon topics), it can take up the majority, if not more than that, of the screen, which can get frustrating. For most desktop users and for small verses this isn't a problem but I do think having the option to insert small is a good idea

  1. There have been too many setting toggles, we should try not add more.

I agree that we have a lot of tagging ones but it seems like there are already changes in the works to deal with this; personally I'd always rather customizability over removing options. If you're adamant on this position, could I suggest a compromise of sorting the settings into collapsible toggles?

(I'll also note I did want to make this toggle only visible when collapsible was enabled in the first place but didn't yet know how to do that; that's a change that could be implemented in a few other places too too simplify things, as part of a potential UI update pr later)

@minermaniac447 thanks for understanding.

Would you like to make the changes?

If so, I will merge and make it happen in next release.

minermaniac447 commented 1 year ago

Yep, I can put the change in. If you do want to revisit this idea later, let me know!

tim-hub commented 1 year ago

Yep, I can put the change in. If you do want to revisit this idea later, let me know!

Thanks,