tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
239 stars 42 forks source link

Please add Spanish Book Names #138

Closed oscampo closed 1 year ago

oscampo commented 1 year ago

Thanks in advance!!

tim-hub commented 1 year ago

Hi @oscampo

Would you mind helping add the Spanish translation book names?

This is the repo to have different translations,

ref: https://github.com/AntiochTechnology/bible-reference-toolkit/tree/master/packages/bible-book-names-intl/src/data/translations

It is a JSON file in a spercific structure, there are 3 langauges there, if you can help for Spanish, that will be great

feel free to ping me if need help

tim-hub commented 1 year ago

this is duplicated of https://github.com/tim-hub/obsidian-bible-reference/issues/134

oscampo commented 1 year ago

Hi @oscampo

Would you mind helping add the Spanish translation book names?

This is the repo to have different translations,

ref: https://github.com/AntiochTechnology/bible-reference-toolkit/tree/master/packages/bible-book-names-intl/src/data/translations

It is a JSON file in a spercific structure, there are 3 langauges there, if you can help for Spanish, that will be great

feel free to ping me if need help Great! I just created the file "sp.json" following the format you suggest. Here is the file: spanishBookNames.zip

oscampo commented 1 year ago

Hi, Any problem with the json file ? I saw some reports of errors in the build, but they are related to my file?... sorry I'm checking the report but I can't find which are the errors on my file, because I only see some errors related to another file with book names in english

tim-hub commented 1 year ago

Hi, Any problem with the json file ? I saw some reports of errors in the build, but they are related to my file?... sorry I'm checking the report but I can't find which are the errors on my file, because I only see some errors related to another file with book names in english

I should update the markdown file I think, some information missed in the doc. 😅😅

The tests will check the files structure and whether there are duplication.

Will check tomorrow and update the readme and let you know the reason why test failed.

oscampo commented 1 year ago

Ok... I understand... maybe there is a problem with the name "Job" because is the same for the name of the book end for the short name

oscampo commented 1 year ago

@tim-hub I check the json file and updated with unique or blank shortnames

tim-hub commented 1 year ago

@tim-hub I check the json file and updated with unique or blank shortnames

Thanks

oscampo commented 1 year ago

Hi @tim-hub I check you merged sp.json last week, but the obsidian plugin is not updated. Any idea when the version with spanish book names will be available?

tim-hub commented 1 year ago

Sorry for that, the lib need to be updated to use the Spanish translation

tim-hub commented 1 year ago

Working on it

tim-hub commented 1 year ago

@oscampo

This should be fixed in version 2.2.0, Thanks for the patience.

https://github.com/tim-hub/obsidian-bible-reference/releases/tag/2.2.0