tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
225 stars 41 forks source link

Please add Spanish Book Names #138

Closed oscampo closed 11 months ago

oscampo commented 12 months ago

Thanks in advance!!

tim-hub commented 12 months ago

Hi @oscampo

Would you mind helping add the Spanish translation book names?

This is the repo to have different translations,

ref: https://github.com/AntiochTechnology/bible-reference-toolkit/tree/master/packages/bible-book-names-intl/src/data/translations

It is a JSON file in a spercific structure, there are 3 langauges there, if you can help for Spanish, that will be great

feel free to ping me if need help

tim-hub commented 12 months ago

this is duplicated of https://github.com/tim-hub/obsidian-bible-reference/issues/134

oscampo commented 12 months ago

Hi @oscampo

Would you mind helping add the Spanish translation book names?

This is the repo to have different translations,

ref: https://github.com/AntiochTechnology/bible-reference-toolkit/tree/master/packages/bible-book-names-intl/src/data/translations

It is a JSON file in a spercific structure, there are 3 langauges there, if you can help for Spanish, that will be great

feel free to ping me if need help Great! I just created the file "sp.json" following the format you suggest. Here is the file: spanishBookNames.zip

oscampo commented 12 months ago

Hi, Any problem with the json file ? I saw some reports of errors in the build, but they are related to my file?... sorry I'm checking the report but I can't find which are the errors on my file, because I only see some errors related to another file with book names in english

tim-hub commented 12 months ago

Hi, Any problem with the json file ? I saw some reports of errors in the build, but they are related to my file?... sorry I'm checking the report but I can't find which are the errors on my file, because I only see some errors related to another file with book names in english

I should update the markdown file I think, some information missed in the doc. 😅😅

The tests will check the files structure and whether there are duplication.

Will check tomorrow and update the readme and let you know the reason why test failed.

oscampo commented 12 months ago

Ok... I understand... maybe there is a problem with the name "Job" because is the same for the name of the book end for the short name

oscampo commented 11 months ago

@tim-hub I check the json file and updated with unique or blank shortnames

tim-hub commented 11 months ago

@tim-hub I check the json file and updated with unique or blank shortnames

Thanks

oscampo commented 11 months ago

Hi @tim-hub I check you merged sp.json last week, but the obsidian plugin is not updated. Any idea when the version with spanish book names will be available?

tim-hub commented 11 months ago

Sorry for that, the lib need to be updated to use the Spanish translation

tim-hub commented 11 months ago

Working on it

tim-hub commented 11 months ago

@oscampo

This should be fixed in version 2.2.0, Thanks for the patience.

https://github.com/tim-hub/obsidian-bible-reference/releases/tag/2.2.0