tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
225 stars 41 forks source link

Unable to look up numbered books #139

Closed chrisg32 closed 11 months ago

chrisg32 commented 12 months ago

Describe the bug I am unable to resolve any numbered books (1 Peter, 2 Corinthians, etc). I have tried from the notes and the lookup dialog, with and without spaces, and with several variations from src/data/abbreviations.ts.

To Reproduce Steps to reproduce the behavior:

  1. Inside a note type --1Peter2:20

  2. The verse will be resolved.

  3. From the verse lookup dialog type 2Cor1:3-4

  4. The verse will not be resolved.

Expected behavior Numbered books should be able to be resolved.

Screenshots

image

image

What Device Do You Use(please complete the following information):

Additional context Bolls life ESV translation.

tim-hub commented 11 months ago

This one seems like related to this one. https://github.com/tim-hub/obsidian-bible-reference/issues/66

I believe it is from upstream library, when handle the book names,

Will try to resolve this by end of the week

nRICHd commented 11 months ago

This problem still exists, irrespective of the english translation used - I have the latest version of Obsidian (1.4.14) running on Mac OS, with plug-in version (2.1.4).

Thanks.

tim-hub commented 11 months ago

This problem still exists, irrespective of the english translation used - I have the latest version of Obsidian (1.4.14) running on Mac OS, with plug-in version (2.1.4).

Thanks.

Yeah, it hasn't been fixed.

Still In progress

tim-hub commented 11 months ago

Sorry for the delay,

Recently was quite busy, will try bring it this weekend.

tim-hub commented 11 months ago

This should be fixed in version 2.2.0, Thanks for the patience.

https://github.com/tim-hub/obsidian-bible-reference/releases/tag/2.2.0

nRICHd commented 11 months ago

Thanks Tim.

All good from my side.