search

tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
239 stars 42 forks source link

Spanish short "two letter" names not working (version 2.3.4) #149

Closed oscampo closed 1 year ago

oscampo commented 1 year ago

Short "2 letter" names as "Gn", "Ex", "Lv", "Nm"...... "Mt", "Mr", "Lc" , "Jn".... and short names as: "1Cor", "2Cor" not work in version 2.3.4

Device: DESKTOP Processor Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz 2.59 GHz Installed RAM 16.0 GB (15.8 GB usable) System type 64-bit operating system, x64-based processor OS: Windows 11 Home Single Language Version 22H2 Installed on ‎20/‎10/‎2022 OS build 22621.2428 Experience Windows Feature Experience Pack 1000.22674.1000.0

tim-hub commented 1 year ago

Hi @oscampo

I can reproduce this issue too, checking it now

oscampo commented 1 year ago

Hi @tim-hub The problem is that the code of sp.json was not updated with the last one I commited wich contains the correct short names Here is the right one: sp.json

tim-hub commented 1 year ago

I think besides the issue you mentiond, there is another one here. the regex trigger requires 3 letters at least.

https://github.com/tim-hub/obsidian-bible-reference/blob/a2a2cf50ef2f4d3aef6d91b5ca9aa05a3c4d5d26/src/utils/regs.ts#L16

tim-hub commented 1 year ago

this release should gets the fix, feel free to let me know if you still get the same issue.

https://github.com/tim-hub/obsidian-bible-reference/releases/tag/2.3.6

oscampo commented 1 year ago

Thanks @tim-hub I just installed this release and I will check it