tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
221 stars 41 forks source link

Fixed display of book names with spaces #154

Closed diatche closed 8 months ago

diatche commented 9 months ago

Currently, the query --2 Samuel 7:16 creates the following output:

> [!bible]+ [2 Samuel 7:16 - KJV](https://bible-api.com/2 Samuel+7:16?translation=kjv)
>  16. And thine house and thy kingdom shall be established for ever before thee: thy throne shall be established for ever.
Screenshot 2023-11-10 at 11 21 30 AM

This has a space in the query path, which prevents the link label from being displayed correctly.

This PR replaces spaces with +, which gives the following output:

> [!bible]+ [2 Samuel 7:16 - KJV](https://bible-api.com/2+Samuel+7:16?translation=kjv)
>  16. And thine house and thy kingdom shall be established for ever before thee: thy throne shall be established for ever.
Screenshot 2023-11-10 at 11 21 41 AM
tim-hub commented 8 months ago

@all-contributors please add @diatche for code

allcontributors[bot] commented 8 months ago

@tim-hub

I've put up a pull request to add @diatche! :tada: