search

tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
221 stars 41 forks source link

verse links broken in various epistles #161

Closed kdave5 closed 8 months ago

kdave5 commented 8 months ago

Describe the bug Whenever a verse is chosen from an epistle that is more than one (i.e. 1 or 2 Corinthians, 1 or 2 Peter, etc.) the link formatting for bible-api.com links break because of a missing + between the number and the epistle.

To Reproduce Steps to reproduce the behavior:

  1. Set verses to include bible-api reference and collapsible
  2. Enter verse
  3. Deselect verse
  4. See error

Expected behavior The format should be the same as other books of the Bible.

Screenshots image

What Device Do You Use(please complete the following information):

tim-hub commented 8 months ago

This is a bug here. Thanks for the feedback

tim-hub commented 8 months ago

@kdave5 Can you double check it with latest build?

I could not reproduce it on my side

image

kdave5 commented 8 months ago

I just tested it after updating the plugin. Works as intended.

Thanks

On Tue, Dec 19, 2023 at 2:00 AM Tim @.***> wrote:

@kdave5 https://github.com/kdave5 Can you double check it with latest build?

I could not reproduce it on my side

image.png (view on web) https://github.com/tim-hub/obsidian-bible-reference/assets/2884320/9e9a1c3c-2941-4f47-9afd-52c7ae4c32a9

— Reply to this email directly, view it on GitHub https://github.com/tim-hub/obsidian-bible-reference/issues/161#issuecomment-1862285338, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7GTMWKIOAT5GELIMZQKTD3YKFCRPAVCNFSM6AAAAABAEO4Z46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRSGI4DKMZTHA . You are receiving this because you were mentioned.Message ID: @.***>