search

tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
221 stars 41 forks source link

Add support for german bible names #168

Closed blankton2 closed 7 months ago

blankton2 commented 7 months ago

  1. What language are you looking for? German

  2. What version is it?

  3. Do you know, is there a public bible API for it?

I wrote the de.json File for https://github.com/Antioch-Tech/bible-reference-toolkit/tree/master/packages/bible-book-names-intl/src/data/translations

Please add that file, so that we can use the german Names. de.json

This is my first time submiting code, please be indulgent :)

tim-hub commented 7 months ago

Thanks so much.

Are you familiar with Git/Github? Do you mind creating a PR directly? :)

blankton2 commented 7 months ago

Not yet. I will look into it tomorrow :)

Tim @.***> schrieb am Do., 4. Jan. 2024, 23:32:

Do you know how to create a PR? :)

— Reply to this email directly, view it on GitHub https://github.com/tim-hub/obsidian-bible-reference/issues/168#issuecomment-1877848878, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMKY265DD6UISMUQMTNDFCTYM4UY7AVCNFSM6AAAAABBNTGVTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXHA2DQOBXHA . You are receiving this because you authored the thread.Message ID: @.***>

blankton2 commented 7 months ago

I made a PR