[Bug] (BibleGateway) Hyperlink broken when bookName contains `space`

[abbasou]

Describe the bug When using a version from BibleGateway and the Book Name contains a space (i.e. "1 Timothy," "2 Chronicles," etc.) the link to BibleGateway will be broken. This will cause formatting issues as well.

To Reproduce Steps to reproduce the behavior:

1. Insert a reference from a BibleGateway version where the Book contains a space in the name.
2. See error

Expected behavior The linker should replace the space with a "+" for a proper hyperlink and correct formatting.

Screenshots

What Device Do You Use(please complete the following information):

• Device: Desktop Computer
• OS: Windows 11
• Version 2.4.4

[abbasou]

So in poking around a bit, I came across the following snippet:

var BibleAPIDotComProvider = class extends BaseBibleAPIProvider {
  constructor(bibleVersion) {
    super(bibleVersion);
  }
  /**
   * Build Request Url for Bible-Api.com
   * @param bookName
   * @param chapter
   * @param verses
   * @param versionName
   */
  buildRequestURL(bookName, chapter, verses, versionName) {
    let queryString = `${bookName}+${chapter}:`.replace(/ /g, "+");
    queryString += this.convertVersesToQueryString(verses);
    this._currentQueryUrl = `${this._apiUrl}/${queryString}?translation=${versionName ? versionName : (this == null ? void 0 : this.BibleVersionKey) ? this.BibleVersionKey : ""}`;
    this.bibleGatewayUrl = this.buildBibleGatewayUrl(bookName, chapter, verses);
    return this._currentQueryUrl;
  }

and noticed the .replace function. I moved it down toward the end of the function as so: this.bibleGatewayUrl = this.buildBibleGatewayUrl(bookName, chapter, verses).replace(/ /g, "+"); and restarted Obsidian and lo and behold it worked!

[tim-hub]

Fix in https://github.com/tim-hub/obsidian-bible-reference/releases/tag/2.4.5

Thanks @abbasou