tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
238 stars 42 forks source link

Extra spacing in the Bible verse URL and Tags when entering verse from chapters beginning with number #208

Closed samuelwarang closed 4 months ago

samuelwarang commented 4 months ago

Describe the bug When adding the verse from a chapter with a number at beginning like 1 Samuel, 1 Kings ,2 Kings The text which

To Reproduce Steps to reproduce the behavior:

  1. Go to Obsidian
  2. Start typing a chapter name which beings with a number and for the Bible version I am using KJV
  3. See error

Expected behavior image

image

Screenshots image

image

What Device Do You Use(please complete the following information):

abbasou commented 4 months ago

Can you verify your plugin is up to date? This was address in issue #185 and fixed in release 2.4.5. I just tried it and it works for me, though my links go to BibleGateway, not directly to bible-api.com. image image

The similar issue with the spaces in the tags was also addressed already.

tim-hub commented 4 months ago

Can you verify your plugin is up to date? This was address in issue #185 and fixed in release 2.4.5. I just tried it and it works for me, though my links go to BibleGateway, not directly to bible-api.com. image image

The similar issue with the spaces in the tags was also addressed already.

@RamchandraWarang9822 can you confirm your plugin version?

samuelwarang commented 4 months ago

Hey, I updated it recently to 2.5.6 And the issue is no more

I assume the issue was on my side of not updating

Thank you very much for creating and maintaining this plugin It has been really helpful

God bless you ❤️