search

tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
234 stars 42 forks source link

No spacing between multiple verses #56

Closed bmalchert closed 1 year ago

bmalchert commented 2 years ago

After I reference a range of verses (e.g. --matt20:1-16), and insert the suggested text, there is consistently no space between inserted verses. So the above reference using the ESV translation looks like this after selecting the suggestion:

> [!Bible] 
> “For the kingdom of heaven is like a master of a house who went out
> early in the morning to hire laborers for his vineyard.After agreeing with
> the laborers for a denarius  a day, he sent them into his vineyard. 
> 
  [matt 20:1-2 - ESV](https://bible-api-bff.bai.uno/bolls-life/ESV/40/20/)

Note the lack of spacing between vineyard and After.

The expected result would be to have a whitespace of some kind between each verse in the range.

JPT62089 commented 2 years ago

@tim-hub, This should be resolved with PR #58

tim-hub commented 1 year ago

@tim-hub, This should be resolved with PR #58

Thanks so much for the PR

JPT62089 commented 1 year ago

It looks like this was re-introduced at one point. Should be re-fixed with #74 :)

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tim-hub commented 1 year ago

Hi @bmalchert Can you help to confirm whether this issue still exists or not?

After #74

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.